Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: use await in filehandle.truncate() snippet #38939

Closed
wants to merge 1 commit into from
Closed

docs: use await in filehandle.truncate() snippet #38939

wants to merge 1 commit into from

Conversation

RA80533
Copy link
Contributor

@RA80533 RA80533 commented Jun 5, 2021

The example snippet of filehandle.close() uses the await keyword
based on convention. This change updates the example snippet of
filehandle.truncate() to similarly use the keyword for the purposes of
consistency.

@RA80533
docs: use await in filehandle.truncate() snippet
9aaa5e3 
The example snippet of filehandle.close() uses the `await` keyword
based on convention. This change updates the example snippet of
filehandle.truncate() to similarly use the keyword for the purposes of
consistency.
@github-actions github-actions bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Jun 5, 2021
@targos
Copy link
Member

targos commented Jun 5, 2021

/cc @jasnell who I think wrote this line.

@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 5, 2021
@Lxxyx Lxxyx added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 11, 2021
Lxxyx pushed a commit that referenced this pull request Jun 11, 2021
@RA80533 @Lxxyx
doc: use await in filehandle.truncate() snippet
bf2473d 
The example snippet of filehandle.close() uses the `await` keyword
based on convention. This change updates the example snippet of
filehandle.truncate() to similarly use the keyword for the purposes of
consistency.

PR-URL: #38939
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
@Lxxyx
Copy link
Member

Lxxyx commented Jun 11, 2021

Landed in bf2473d

@Lxxyx Lxxyx closed this Jun 11, 2021
targos pushed a commit that referenced this pull request Jun 11, 2021
@RA80533 @targos
doc: use await in filehandle.truncate() snippet
405b50c 
The example snippet of filehandle.close() uses the `await` keyword
based on convention. This change updates the example snippet of
filehandle.truncate() to similarly use the keyword for the purposes of
consistency.

PR-URL: #38939
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
@danielleadams danielleadams mentioned this pull request Jun 14, 2021
Merged
danielleadams pushed a commit that referenced this pull request Jun 17, 2021
@RA80533 @danielleadams
doc: use await in filehandle.truncate() snippet
14a0ed0 
The example snippet of filehandle.close() uses the `await` keyword
based on convention. This change updates the example snippet of
filehandle.truncate() to similarly use the keyword for the purposes of
consistency.

PR-URL: #38939
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
@richardlau
Copy link
Member

Backport to v14.x-staging blocked on #37170.

targos pushed a commit that referenced this pull request Sep 4, 2021
@RA80533 @targos
doc: use await in filehandle.truncate() snippet
f799c46 
The example snippet of filehandle.close() uses the `await` keyword
based on convention. This change updates the example snippet of
filehandle.truncate() to similarly use the keyword for the purposes of
consistency.

PR-URL: #38939
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
@targos targos mentioned this pull request Sep 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

@bl-ue bl-ue bl-ue approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

@ycjcl868 ycjcl868 ycjcl868 approved these changes

@Lxxyx Lxxyx Lxxyx approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.